Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses android-browser-helper #55

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Uses android-browser-helper #55

merged 2 commits into from
Jan 8, 2020

Conversation

andreban
Copy link
Member

@andreban andreban commented Jan 7, 2020

  • Replaces custom-tabs-client with the new library,
    android-browser-helper

@andreban
Copy link
Member Author

andreban commented Jan 7, 2020

Do not merge yet. Will make another commit to use the official release of android-browser-helper.

PEConn
PEConn reviewed Jan 7, 2020
View reviewed changes
Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, Approved once ABH hits stable and we can get rid of jitpack.

@andreban
Uses android-browser-helper
72130db 
- Replaces custom-tabs-client with the new library,
  android-browser-helper
@andreban
Use the official android-browser-helper Library
a8bfeb5 
- Replaces the Jitpack version with the version on the Google
  Maven repository.
@andreban andreban marked this pull request as ready for review January 8, 2020 10:29
@andreban
Copy link
Member Author

andreban commented Jan 8, 2020

Updated to use the library from the Google Maven

@andreban andreban merged commit 9eb0391 into GoogleChromeLabs:master Jan 8, 2020
@andreban andreban mentioned this pull request Jan 9, 2020
Closed
@andreban andreban deleted the android-browser-helper branch February 13, 2020 08:15
@andreban andreban added the enhancement New feature or request label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreban @PEConn